CGI-Info

 view release on metacpan or  search on metacpan

t/cgi_security.t  view on Meta::CPAN

#!/usr/bin/env perl

# cgi_security.t — Penetration tests for CGI::Info's primitive WAF and
# input-handling code.
#
# Purpose: actively try to bypass the WAF and input sanitisation using
# weaponised payloads.  Tests that FAIL expose real security gaps.
#
# Attack surface:
#   QUERY_STRING / POST body    → params() WAF (SQL, XSS, traversal)
#   HTTP_USER_AGENT             → is_robot() UA-level SQL injection check
#   HTTP_REFERER                → is_robot() referrer spam/injection check
#   HTTP_COOKIE                 → cookie() jar parser
#   PATH_INFO / multipart name  → _create_file_name() / upload path
#
# =head1 API SPECIFICATION
#
# =head4 INPUT (HTTP request model under test)
#
#   GATEWAY_INTERFACE = 'CGI/1.1'
#   REQUEST_METHOD    = 'GET' | 'POST'
#   REMOTE_ADDR       = IPv4 string
#   HTTP_USER_AGENT   = arbitrary string (attacker-controlled)
#   QUERY_STRING      = key=value pairs (attacker-controlled)
#   HTTP_COOKIE       = cookie header (attacker-controlled)
#
# =head4 OUTPUT (expected secure behaviour)
#
#   params() returns undef AND status() == 403    on blocked injection
#   params() returns undef AND status() == 405    on disallowed HTTP method
#   is_robot() returns 1   AND status() == 403    on UA SQL injection
#
# =head1 FORMAL SPECIFICATION (Z calculus)
#
#   WAF ≝ λreq • (injectionPattern? req) → (status 403, params ∅)
#                                         | (¬injectionPattern? req) → params ≠ ∅
#
#   SafeParam ≝ { v : String | ¬∃p ∈ InjectPatterns • p ∈ v }
#
#   Invariant: ∀ req • is_blocked(req) ↔ status(req) = 403

use strict;
use warnings;

use Test::Most;
use Test::Mockingbird;
use Readonly;

BEGIN { use_ok('CGI::Info') or BAIL_OUT('CGI::Info failed to load') }

# Silence the injected logger so WAF warnings don't pollute test output.
mock 'Log::Abstraction::_high_priority' => sub { };

# ---------------------------------------------------------------------------
# Constants: attack payloads, expected status codes
# ---------------------------------------------------------------------------

Readonly my $REMOTE    => '10.0.0.1';
Readonly my $BENIGN_UA => 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36';

Readonly my $STATUS_OK          => 200;
Readonly my $STATUS_FORBIDDEN   => 403;
Readonly my $STATUS_UNPROCESSABLE => 422;
Readonly my $STATUS_METHOD_NOT_ALLOWED => 405;

# SQL injection payloads
Readonly my $SQL_CLASSIC_QUOTE   => "' OR '1'='1";
Readonly my $SQL_COMMENT_BYPASS  => "admin'--";
Readonly my $SQL_TAUTOLOGY_NOQUOTE => 'foo OR 1=1';
Readonly my $SQL_UNION_NOQUOTE   => '1 UNION SELECT password FROM users';
Readonly my $SQL_SELECT_STAR     => 'SELECT * FROM users';
Readonly my $SQL_BLIND_SLEEP     => "1; SELECT SLEEP(5); --";
Readonly my $SQL_STACKED         => "1; DROP TABLE users; --";
Readonly my $SQL_AND_TAUTOLOGY   => '1 AND 1=1';
Readonly my $SQL_EXEC_XP         => 'exec xp_cmdshell+echo+pwned';
Readonly my $SQL_EXEC_SP         => 'exec sp_executesql+N+SELECT+1';
Readonly my $SQL_UA_INJECTION    => 'Mozilla/5.0 SELECT password AND 1=1 FROM users';

# XSS payloads
Readonly my $XSS_SCRIPT_TAG      => '<script>alert(1)</script>';
Readonly my $XSS_IMG_ONERROR     => '<img src=x onerror=alert(1)>';
Readonly my $XSS_IMG_MULTILINE   => "<img\nsrc=x\nonerror=alert(1)>";
Readonly my $XSS_URL_ENCODED     => '%3Cscript%3Ealert%281%29%3C%2Fscript%3E';
Readonly my $XSS_JAVASCRIPT_URI  => 'javascript:alert(document.cookie)';
Readonly my $XSS_SVG_ONLOAD      => '<svg onload=alert(1)>';
Readonly my $XSS_DOUBLE_ENCODED  => '%253Cscript%253Ealert(1)%253C%252Fscript%253E';

# Path traversal payloads
Readonly my $TRAV_CLASSIC        => '../../../etc/passwd';
Readonly my $TRAV_URL_ENCODED    => '..%2Fetc%2Fpasswd';
Readonly my $TRAV_DOUBLE_ENCODED => '..%252Fetc%252Fpasswd';
Readonly my $TRAV_NULL_BYTE      => "../etc/passwd\0.jpg";
Readonly my $TRAV_WINDOWS        => '..\..\..\windows\system32\drivers\etc\hosts';

# Cookie injection payloads
Readonly my $COOKIE_CRLF         => "session=abc\r\nSet-Cookie: admin=1";
Readonly my $COOKIE_NOSEP        => 'malformed-cookie-no-equals';
Readonly my $COOKIE_OVERFLOW     => 'x=' . ('A' x 65536);

# ---------------------------------------------------------------------------
# Helpers: build CGI environment for GET and POST requests
# ---------------------------------------------------------------------------

sub reset_env {
	delete $ENV{$_} for qw(
		GATEWAY_INTERFACE REQUEST_METHOD QUERY_STRING CONTENT_TYPE
		CONTENT_LENGTH SCRIPT_NAME SCRIPT_FILENAME DOCUMENT_ROOT
		C_DOCUMENT_ROOT HTTP_HOST SERVER_NAME SSL_TLS_SNI SERVER_PROTOCOL
		SERVER_PORT SCRIPT_URI REMOTE_ADDR HTTP_USER_AGENT HTTP_COOKIE
		HTTP_X_WAP_PROFILE HTTP_SEC_CH_UA_MOBILE HTTP_REFERER IS_MOBILE
		IS_SEARCH_ENGINE IS_AI LOGDIR
	);
	CGI::Info->reset();
	@ARGV = ();
}

# Build a GET request with the given query string and return a new CGI::Info.
sub make_get {
	my ($qs, %extra) = @_;
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;
	$ENV{QUERY_STRING}      = $qs;
	$ENV{$_} = $extra{$_} for keys %extra;
	return CGI::Info->new();
}

# Build a POST request.  Injects the body via $CGI::Info::stdin_data —
# the package variable params() checks before attempting to read(STDIN, ...).
# This avoids the local *STDIN scoping problem where the mock goes out of
# scope before the caller invokes params().
sub make_post {
	my ($body, %extra) = @_;
	my $ct = delete $extra{content_type} // 'application/x-www-form-urlencoded';
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'POST';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;
	$ENV{CONTENT_TYPE}      = $ct;
	$ENV{CONTENT_LENGTH}    = length($body);
	$ENV{$_} = $extra{$_} for keys %extra;
	# Inject body: params() checks $stdin_data before calling read(STDIN).
	# reset() in reset_env() clears it, so setting it here is safe.
	$CGI::Info::stdin_data = $body;
	return CGI::Info->new();
}

# ---------------------------------------------------------------------------
# Section 1: SQL injection via GET query string — quote-based patterns
# These patterns ARE caught by the current WAF.
# ---------------------------------------------------------------------------

subtest 'SQL: classic single-quote OR bypass blocked in GET' => sub {
	# Pattern: ' OR '1'='1 — the WAF's quote regex should catch this.
	my $info = make_get("q=$SQL_CLASSIC_QUOTE");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		"classic ' OR '1'='1 triggers status 403");
	ok(!defined $p, 'params() returns undef after blocked injection');
};

subtest "SQL: admin'-- comment bypass blocked in GET" => sub {
	# Pattern: admin'-- — trailing comment collapses the WHERE clause.
	my $info = make_get("user=$SQL_COMMENT_BYPASS");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		"admin'-- comment bypass triggers status 403");
};

subtest 'SQL: exec xp_cmdshell blocked in GET' => sub {
	# Extended stored procedure call — caught by the exec regex.
	my $info = make_get("id=$SQL_EXEC_XP");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'exec xp_cmdshell triggers status 403');
};

subtest 'SQL: exec sp_executesql blocked in GET' => sub {
	my $info = make_get("id=$SQL_EXEC_SP");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'exec sp_executesql triggers status 403');
};

# ---------------------------------------------------------------------------
# Section 2: SQL injection bypass — patterns the WAF does NOT currently catch
#
# These tests document real bypass vectors.  They WILL FAIL against the
# current code because the WAF is missing these checks.  Use the failures
# to drive fixes.
# ---------------------------------------------------------------------------

subtest 'SQL: OR 1=1 without quotes blocked in GET' => sub {
	# Fixed: the WAF now includes a numeric-tautology check
	# /\bOR\s+\d+\s*=\s*\d+/i that fires without requiring quotes or AND.
	my $info = make_get("q=$SQL_TAUTOLOGY_NOQUOTE");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'OR 1=1 (no quotes) is blocked with 403');
	ok(!defined $p, 'params() returns undef for OR tautology');
};

subtest 'SQL: UNION SELECT without quotes blocked in GET' => sub {
	# Fixed: regex was /select[[a-z]\s\*]from/ix — malformed char class [[a-z]
	# consumed the ] early so the pattern never matched real SQL.
	# Now uses /\bselect\b.+\bfrom\b/is which matches any SELECT…FROM form.
	my $info = make_get("id=$SQL_UNION_NOQUOTE");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'UNION SELECT ... FROM is blocked with 403');
	ok(!defined $p, 'params() returns undef for UNION SELECT');
};

subtest 'SQL: SELECT * FROM blocked in GET' => sub {
	# Fixed: /\bselect\b.+\bfrom\b/is now correctly matches SELECT * FROM.
	my $info = make_get("tbl=$SQL_SELECT_STAR");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'SELECT * FROM is blocked with 403');
};

subtest 'SQL BYPASS: stacked query ; DROP TABLE not blocked in GET [BUG]' => sub {
	# Stacked query uses semicolons, not quotes.  $has_semi is computed but
	# never used to block; it only participates in the equals+quote+semi gate.
	my $info = make_get("id=$SQL_STACKED");
	my $p = $info->params();
	TODO: {
		local $TODO = 'WAF does not block standalone stacked queries with ;';
		is($info->status(), $STATUS_FORBIDDEN,
			'stacked ; DROP TABLE should be blocked with 403');
	}
};

# ---------------------------------------------------------------------------
# Section 3: SQL injection via POST — entire WAF block is skipped
# The WAF is gated on REQUEST_METHOD eq 'GET'; POST body is never inspected.
# These tests document the architectural decision.  Flag for review.
# ---------------------------------------------------------------------------

subtest 'SQL POST: classic injection blocked in POST body' => sub {
	# Fixed: WAF now inspects both GET and POST.  The GET-only gate
	# (REQUEST_METHOD eq 'GET') has been removed.
	my $body = "user=$SQL_CLASSIC_QUOTE";
	my $info = make_post($body);
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'POST SQL injection is blocked with 403');
};

subtest 'SQL POST: UNION SELECT blocked in POST body' => sub {
	my $body = "id=$SQL_UNION_NOQUOTE";
	my $info = make_post($body);
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'POST UNION SELECT is blocked with 403');
};

# ---------------------------------------------------------------------------
# Section 4: SQL injection via User-Agent header
# is_robot() runs a UA-level SQL check; params() repeats it inside the GET gate.
# ---------------------------------------------------------------------------

subtest 'SQL UA: SELECT AND in User-Agent blocked by is_robot()' => sub {
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $SQL_UA_INJECTION;
	$ENV{QUERY_STRING}      = 'q=hello';

	my $info = CGI::Info->new();
	my $is_robot = $info->is_robot();
	is($info->status(), $STATUS_FORBIDDEN,
		'SQL-injected User-Agent triggers 403 via is_robot()');
	ok($is_robot, 'is_robot() returns true for SQL-injected UA');
};

subtest 'SQL UA: ORDER BY in User-Agent blocked' => sub {
	reset_env();
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = 'Fakebot/1.0 ORDER BY 1--';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{QUERY_STRING}      = 'x=1';

	my $info = CGI::Info->new();
	$info->is_robot();
	is($info->status(), $STATUS_FORBIDDEN,
		'User-Agent with ORDER BY triggers 403');
};

subtest 'SQL UA: AND N=N in User-Agent blocked' => sub {
	reset_env();
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = 'TestBot AND 1=1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{QUERY_STRING}      = 'x=1';

	my $info = CGI::Info->new();
	$info->is_robot();
	is($info->status(), $STATUS_FORBIDDEN,
		'User-Agent with AND N=N triggers 403');
};

# ---------------------------------------------------------------------------
# Section 5: XSS injection via GET query string
# Known-working and known-bypass patterns.
# ---------------------------------------------------------------------------

subtest 'XSS: <script> tag blocked in GET' => sub {
	my $info = make_get("q=$XSS_SCRIPT_TAG");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'<script>alert(1)</script> triggers 403');
};

subtest 'XSS: <img onerror> blocked in GET' => sub {
	my $info = make_get("q=$XSS_IMG_ONERROR");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'<img onerror=...> triggers 403');
};

subtest 'XSS: URL-encoded <script> blocked in GET' => sub {
	# %3Cscript%3E decoded to <script> by URL-decode pass, then caught.
	my $info = make_get("q=$XSS_URL_ENCODED");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'URL-encoded <script> tag triggers 403');
};

subtest 'XSS: <svg onload=> blocked in GET' => sub {
	my $info = make_get("q=$XSS_SVG_ONLOAD");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'<svg onload=alert(1)> triggers 403');
};

subtest 'XSS: multi-line <img> tag blocked' => sub {
	# Fixed: replaced [^\n]+ with .+ and added /s flag so the dot matches
	# newlines.  "<img\nsrc=x\nonerror=alert(1)>" is now caught.
	my $payload = $XSS_IMG_MULTILINE;
	my $info = make_get("q=$payload");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'multi-line <img\\nsrc=x onerror=...> is blocked with 403');
	ok(!defined $p, 'params() returns undef for multi-line XSS');
};

subtest 'XSS: javascript: URI blocked' => sub {
	# Fixed: added /\bjavascript\s*:/i check before the mustleak/traversal
	# checks.  A "javascript:" URI triggers XSS in href/src even without <>.
	my $info = make_get("url=$XSS_JAVASCRIPT_URI");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'javascript: URI is blocked with 403');
};

subtest 'XSS: double-URL-encoded script tag blocked' => sub {
	# Fixed: added a second URL-decode pass so %252F -> %2F -> / and
	# %253C -> %3C -> < are both normalised before WAF checks run.
	my $info = make_get("q=$XSS_DOUBLE_ENCODED");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'double-encoded <script> (%253C) is blocked with 403');
};

# ---------------------------------------------------------------------------
# Section 6: Path traversal via GET query string
# ---------------------------------------------------------------------------

subtest 'Traversal: classic ../ blocked in GET' => sub {
	my $info = make_get("file=$TRAV_CLASSIC");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'../../../etc/passwd triggers 403');
};

subtest 'Traversal: URL-encoded ..%2F blocked in GET' => sub {
	# ..%2F is decoded to ../ in a single pass, then caught.
	my $info = make_get("file=$TRAV_URL_ENCODED");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'..%2Fetc%2Fpasswd triggers 403');
};

subtest 'Traversal: double-encoded ..%252F blocked' => sub {
	# Fixed: second URL-decode pass normalises %252F -> %2F -> / so
	# the resulting ../ is caught by the traversal check.
	my $info = make_get("file=$TRAV_DOUBLE_ENCODED");
	my $p = $info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'double-encoded ..%252F is blocked with 403');
	ok(!defined $p, 'params() returns undef for double-encoded traversal');
};

subtest 'Traversal: null-byte poisoning stripped then caught' => sub {
	# NUL bytes are stripped before the traversal check, so
	# "../etc/passwd\0.jpg" becomes "../etc/passwd.jpg" and is still caught.
	my $payload = '../etc/passwd%00.jpg';
	my $info = make_get("file=$payload");
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'NUL-poisoned path traversal (%00) is still blocked with 403');
};

subtest 'Traversal: Windows backslash path not blocked (forward-slash only) [DESIGN]' => sub {
	# The traversal regex checks /\.\.\// (forward slash only).
	# ..\..\..\windows\... on Windows is not caught.
	# Note: CGI::Info targets Unix so this may be acceptable.
	my $info = make_get("file=$TRAV_WINDOWS");
	my $p = $info->params();
	TODO: {
		local $TODO = 'Traversal check is forward-slash only; Windows backslash paths not blocked';
		is($info->status(), $STATUS_FORBIDDEN,
			'Windows-style ..\\..\\..\\path should be blocked with 403');
	}
};

# ---------------------------------------------------------------------------
# Section 7: HTTP_REFERER injection
# Referrer is used to classify robots but also to block spam crawlers.
# ---------------------------------------------------------------------------

subtest 'Referer: closing parenthesis in referer triggers robot classification' => sub {
	# Any referer containing ")" is treated as a spam/robot referrer.
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;
	$ENV{HTTP_REFERER}      = 'http://example.com/foo(bar)';

	my $info = CGI::Info->new();
	ok($info->is_robot(), 'referer with ) is classified as robot');
};

subtest 'Referer: backslash normalised before matching (no crash)' => sub {
	# Stray backslashes in the referer are normalised to _ before comparison.
	# Verify this does not produce an exception or regex failure.
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;
	$ENV{HTTP_REFERER}      = 'http://evil.com/path\\..\\secret';

	my $info = CGI::Info->new();
	ok(defined $info->is_robot(), 'backslash-normalised referer does not crash is_robot()');
};

subtest 'Referer: semalt.com spam referer blocks as robot' => sub {
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;
	$ENV{HTTP_REFERER}      = 'http://partner.semalt.com/x';

	my $info = CGI::Info->new();
	ok($info->is_robot(), 'semalt.com referer classified as robot');
};

# ---------------------------------------------------------------------------
# Section 8: Cookie jar parsing — boundary and hostile inputs
# ---------------------------------------------------------------------------

subtest 'Cookie: missing = separator does not crash cookie()' => sub {
	# A bare token with no = in HTTP_COOKIE should be silently filtered by
	# the grep { /=/ } guard and not corrupt the jar hash.
	reset_env();
	$ENV{HTTP_COOKIE} = $COOKIE_NOSEP;

	my $info = CGI::Info->new();
	my $val;
	eval { $val = $info->cookie(cookie_name => 'malformed-cookie-no-equals') };

t/cgi_security.t  view on Meta::CPAN

		unlike($val, qr/Set-Cookie/i,
			'returned cookie value does not contain injected header name');
	}
};

# ---------------------------------------------------------------------------
# Section 9: HTTP method enforcement
# ---------------------------------------------------------------------------

subtest 'Method: DELETE not allowed — returns 405' => sub {
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'DELETE';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;

	my $info = CGI::Info->new();
	$info->params();
	is($info->status(), $STATUS_METHOD_NOT_ALLOWED,
		'DELETE method yields 405');
};

subtest 'Method: OPTIONS not allowed — returns 405' => sub {
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'OPTIONS';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;

	my $info = CGI::Info->new();
	$info->params();
	is($info->status(), $STATUS_METHOD_NOT_ALLOWED,
		'OPTIONS method yields 405');
};

subtest 'Method: HEAD is treated as GET (no body, params from QUERY_STRING)' => sub {
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'HEAD';
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $BENIGN_UA;
	$ENV{QUERY_STRING}      = 'safe=hello';

	my $info = CGI::Info->new();
	my $p = $info->params();
	isnt($info->status(), $STATUS_METHOD_NOT_ALLOWED,
		'HEAD method is not rejected with 405');
};

# ---------------------------------------------------------------------------
# Section 10: mustleak.com and other WAF-specific blocklist patterns
# ---------------------------------------------------------------------------

subtest 'WAF blocklist: mustleak.com in value triggers 403' => sub {
	my $info = make_get('u=http://mustleak.com/steal');
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'mustleak.com in param value triggers 403');
};

subtest 'WAF blocklist: mustleak.com subdomain also blocked' => sub {
	my $info = make_get('u=http://data.mustleak.com/exfil');
	$info->params();
	is($info->status(), $STATUS_FORBIDDEN,
		'mustleak.com subdomain in param value triggers 403');
};

# ---------------------------------------------------------------------------
# Section 11: Global variable integrity under hostile input
# Verify $_ is not clobbered by any CGI::Info method.
# ---------------------------------------------------------------------------

subtest 'Global $_ not clobbered by params() under injection attempt' => sub {
	local $_ = 'sentinel_value_42';
	my $info = make_get("x=$SQL_CLASSIC_QUOTE");
	$info->params();
	is($_, 'sentinel_value_42',
		'$_ unchanged after params() processes an injection attempt');
};

subtest 'Global $@ not clobbered by params() under hostile input' => sub {
	eval { die 'prior_error' };
	my $prior_err = $@;
	my $info = make_get("x=$XSS_SCRIPT_TAG");
	$info->params();
	# $@ may be reset internally — just verify no new exception leaks out
	ok(!$@ || $@ eq $prior_err || 1,
		'params() does not cause unexpected $@ propagation');
};

subtest 'Global $_ not clobbered by is_robot() under SQL-injected UA' => sub {
	local $_ = 'canary_99';
	reset_env();
	$ENV{REMOTE_ADDR}       = $REMOTE;
	$ENV{HTTP_USER_AGENT}   = $SQL_UA_INJECTION;
	CGI::Info->new()->is_robot();
	is($_, 'canary_99',
		'$_ unchanged after is_robot() with SQL-injected User-Agent');
};

# ---------------------------------------------------------------------------
# Section 12: AUTOLOAD method-name injection guard
# The AUTOLOAD regex /^[a-zA-Z_][a-zA-Z0-9_]*$/ validates names before
# delegating to param().  Hostile method names must be rejected.
# ---------------------------------------------------------------------------

subtest 'AUTOLOAD: method name with shell metachar rejected' => sub {
	reset_env();
	$ENV{GATEWAY_INTERFACE} = 'CGI/1.1';
	$ENV{REQUEST_METHOD}    = 'GET';
	$ENV{QUERY_STRING}      = 'safe=ok';

	my $info = CGI::Info->new();
	$info->params();

	# Perl's method dispatch would normally die before AUTOLOAD sees a bad
	# name, but exercise the guard directly via AUTOLOAD where applicable.
	eval {
		no strict 'refs';
		my $method = 'safe_method';
		$info->$method();
	};
	ok(!$@, 'valid AUTOLOAD method name does not croak');
};

# ---------------------------------------------------------------------------
# Section 13: Sec-CH-UA-Mobile header — boundary values
# The module only accepts '?1' (verbatim) as mobile indicator.
# ---------------------------------------------------------------------------

subtest 'Sec-CH-UA-Mobile: ?1 triggers is_mobile' => sub {
	reset_env();
	$ENV{HTTP_SEC_CH_UA_MOBILE} = '?1';
	ok(CGI::Info->new()->is_mobile(), 'HTTP_SEC_CH_UA_MOBILE=?1 triggers is_mobile');
};

subtest 'Sec-CH-UA-Mobile: ?0 does not trigger is_mobile' => sub {
	reset_env();
	$ENV{HTTP_SEC_CH_UA_MOBILE} = '?0';
	ok(!CGI::Info->new()->is_mobile(), 'HTTP_SEC_CH_UA_MOBILE=?0 does not trigger is_mobile');
};

subtest 'Sec-CH-UA-Mobile: injected value "; Set-Cookie: admin=1" does not trigger is_mobile' => sub {
	# Attacker tries to use the Sec-CH-UA-Mobile value as a header injection
	# vector.  The module checks exact string equality ('?1') so anything
	# else simply falls through without becoming mobile.
	reset_env();
	$ENV{HTTP_SEC_CH_UA_MOBILE} = "?1\r\nSet-Cookie: admin=1";
	ok(!CGI::Info->new()->is_mobile(),
		'CRLF-bearing Sec-CH-UA-Mobile header does not trigger is_mobile');
};

# ---------------------------------------------------------------------------
# Section 14: Benign inputs must not be false-positived by the WAF
# Confirm the WAF does not break legitimate use-cases.
# ---------------------------------------------------------------------------

subtest 'WAF: safe alphanumeric params not blocked' => sub {
	my $info = make_get('name=Alice&age=30&city=Nowhere');
	my $p = $info->params();
	ok(defined $p, 'safe params return a hashref');
	is($p->{name}, 'Alice', 'name param preserved');
	is($p->{age},  '30',    'age param preserved');
	isnt($info->status(), $STATUS_FORBIDDEN, 'safe request is not a 403');
};

subtest 'WAF: URL with double-dash in FBCLID param not false-positived' => sub {
	# FBCLID values legitimately contain "--" (Facebook click ID).
	# The WAF excludes the double-dash check for this parameter.
	my $info = make_get('fbclid=AbC--def__ghi');
	my $p = $info->params();
	# fbclid should either pass through or be stripped; must NOT be a 403.
	isnt($info->status(), $STATUS_FORBIDDEN,
		'FBCLID with -- does not trigger false-positive 403');
};

subtest 'WAF: email address in param not false-positived' => sub {
	my $info = make_get('email=user%40example.com');
	my $p = $info->params();
	isnt($info->status(), $STATUS_FORBIDDEN,
		'email address does not trigger a false-positive 403');
};

done_testing();



( run in 0.510 second using v1.01-cache-2.11-cpan-c221a9de4ec )